Conversation
|
launch jenkins(debug) |
|
The testsuite you launched for this PR has failed. You can inspect the results at this link. |
|
Test results summary after Antarctica coastal glacier fix The change intentionally modifies output in Antarctic coastal regions to remove unrealistic high-albedo artefacts. All tests pass except for one:
The differences are expected and directly caused by this new correction ! enforce that the lu_class_fractions sum up to 1 (existing code above)
IF (lu_class_fraction(i,j,k,ilu_snow_ice) > 0.01_wp .AND. lat_geo(i,j,k) < -60._wp &
.AND. fr_land_lu(i,j,k) < 0.5_wp .AND. hh_topo(i,j,k) < 100._wp ) THEN
count_frland_ice = count_frland_ice + 1
lu_class_fraction(i,j,k,ilu_snow_ice) = 0.6_wp * fr_land_lu(i,j,k)
lu_class_fraction(i,j,k,ilu_bare_soil) = 0.4_wp * fr_land_lu(i,j,k)
alb_field_mom (i,j,k,1:12) = 0.15_wp
alnid_field_mom (i,j,k,1:12) = 0.15_wp
aluvd_field_mom (i,j,k,1:12) = 0.15_wp
ENDIFOther tests unaffected (as expected):
Recommendation: |
|
Hi @jhelmert, Ok, perfect! Then I will update the references for the failing test and merge this, ok? Also, quick question: As far as I understood, this fix was previously done in the ICON code. Was the fix now removed from ICON? And does everyone that depends on that fix know that it will now be part of EXTPAR (i.e. that they would need to update their external parameter files)? |
This modification from ICON (G. Zängl) transfered to EXTPAR checks if a grid cell at (i,j,k) has >1% snow/ice cover, is south of -60° latitude, has <50% land fraction, and is below 100m elevation.
If true, it:
Sets snow/ice fraction to 60% and bare soil to 40% of the land fraction.
Assigns a constant albedo of 0.15 to broadband, near-infrared, and UV/visible fields for all 12 months.